pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Parse catalog .dat files as a whole when compiling the backend
Date: Thu, 08 Sep 2022 06:57:37 +0000
Message-ID: <E1oWBTl-001xgw-B5@gemulon.postgresql.org> (raw)

Parse catalog .dat files as a whole when compiling the backend

Previously Catalog.pm eval'd each individual hash reference
so that comments and whitespace can be preserved when running
reformat-dat-files. This is unnecessary when building, and we can save
~15% off the run time of genbki.pl by simply slurping and eval'-ing
the whole file at once. This saves a bit of time, especially in highly
parallel builds, since most build targets depend on this script's outputs.

Report and review by Andres Freund
Discussion: https://www.postgresql.org/message-id/CAFBsxsGW%3DWRbnxXrc8UqqR479XuxtukSFWV-hnmtgsbuNAUO6w%40mail.g...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/69eb643b2582f180c91b2d14c896402e54040231

Modified Files
--------------
src/backend/catalog/Catalog.pm | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)



Message-ID: <E1oWBTl-001xgw-B5@gemulon.postgresql.org>
Permalink:  ../E1oWBTl-001xgw-B5@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oWBTl-001xgw-B5@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org
  Subject: Re: pgsql: Parse catalog .dat files as a whole when compiling the backend
  In-Reply-To: <E1oWBTl-001xgw-B5@gemulon.postgresql.org>
  References: <E1oWBTl-001xgw-B5@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox