pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix NaN comparison in circle_same test 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix NaN comparison in circle_same test @ 2022-09-12 11:05 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2022-09-12 11:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row) This fixes the sameness test to consider the radius of both the left and right circle. Backpatch to v12 where this was introduced. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com Backpatch-through: v12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8cb2a22bbb2cf4212482ac15021ceaa2e9c52209 Modified Files -------------- src/backend/utils/adt/geo_ops.c | 2 +- src/test/regress/expected/geometry.out | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix NaN comparison in circle_same test @ 2022-09-12 11:06 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2022-09-12 11:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row) This fixes the sameness test to consider the radius of both the left and right circle. Backpatch to v12 where this was introduced. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com Backpatch-through: v12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/56d238846fe6e1772c8652cd4945da6c0a42534a Modified Files -------------- src/backend/utils/adt/geo_ops.c | 2 +- src/test/regress/expected/geometry.out | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix NaN comparison in circle_same test @ 2022-09-12 11:06 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2022-09-12 11:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row) This fixes the sameness test to consider the radius of both the left and right circle. Backpatch to v12 where this was introduced. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com Backpatch-through: v12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/13b8a1c19626d425176b1e00a8104db1e339aaf3 Modified Files -------------- src/backend/utils/adt/geo_ops.c | 2 +- src/test/regress/expected/geometry.out | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix NaN comparison in circle_same test @ 2022-09-12 11:06 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2022-09-12 11:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row) This fixes the sameness test to consider the radius of both the left and right circle. Backpatch to v12 where this was introduced. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com Backpatch-through: v12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/eb8b848079c3e3f8cd486f209e50d0114476d2e8 Modified Files -------------- src/backend/utils/adt/geo_ops.c | 2 +- src/test/regress/expected/geometry.out | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix NaN comparison in circle_same test @ 2022-09-12 11:07 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2022-09-12 11:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row) This fixes the sameness test to consider the radius of both the left and right circle. Backpatch to v12 where this was introduced. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com Backpatch-through: v12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9ebfbd23bcdefa7cb7abd1ecdd80aa1f9be6eede Modified Files -------------- src/backend/utils/adt/geo_ops.c | 2 +- src/test/regress/expected/geometry.out | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-09-12 11:07 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-09-12 11:05 pgsql: Fix NaN comparison in circle_same test Daniel Gustafsson <dgustafsson@postgresql.org> 2022-09-12 11:06 pgsql: Fix NaN comparison in circle_same test Daniel Gustafsson <dgustafsson@postgresql.org> 2022-09-12 11:06 pgsql: Fix NaN comparison in circle_same test Daniel Gustafsson <dgustafsson@postgresql.org> 2022-09-12 11:06 pgsql: Fix NaN comparison in circle_same test Daniel Gustafsson <dgustafsson@postgresql.org> 2022-09-12 11:07 pgsql: Fix NaN comparison in circle_same test Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox