pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix NaN comparison in circle_same test
Date: Mon, 12 Sep 2022 11:06:39 +0000
Message-ID: <E1oXhGx-002dcC-0v@gemulon.postgresql.org> (raw)

Fix NaN comparison in circle_same test

Commit c4c340088 changed geometric operators to use float4 and float8
functions, and handle NaN's in a better way. The circle sameness test
had a typo in the code which resulted in all comparisons with the left
circle having a NaN radius considered same.

  postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle;
  ?column?
  ----------
  t
  (1 row)

This fixes the sameness test to consider the radius of both the left
and right circle.

Backpatch to v12 where this was introduced.

Author: Ranier Vilela <ranier.vf@gmail.com>
Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com
Backpatch-through: v12

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/13b8a1c19626d425176b1e00a8104db1e339aaf3

Modified Files
--------------
src/backend/utils/adt/geo_ops.c        | 2 +-
src/test/regress/expected/geometry.out | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1oXhGx-002dcC-0v@gemulon.postgresql.org>
Permalink:  ../E1oXhGx-002dcC-0v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oXhGx-002dcC-0v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Fix NaN comparison in circle_same test
  In-Reply-To: <E1oXhGx-002dcC-0v@gemulon.postgresql.org>
  References: <E1oXhGx-002dcC-0v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox