pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't reference out-of-bounds array elements in brin_minmax_mult
Date: Mon, 12 Sep 2022 23:05:40 +0000
Message-ID: <E1oXsUl-0004dK-Ls@gemulon.postgresql.org> (raw)

Don't reference out-of-bounds array elements in brin_minmax_multi.c

The primary fix here is to fix has_matching_range() so it does not
reference ranges->values[-1] when nranges == 0.  Similar problems existed
in AssertCheckRanges() too.  It does not look like any of these problems
could lead to a crash as the array in question is at the end of the Ranges
struct, and values[-1] is memory that belongs to other fields in the
struct.  However, let's get rid of these rather unsafe coding practices.

In passing, I (David) adjusted some comments to try to make it more clear
what some of the fields are for in the Ranges struct.  I had to study the
code to find out what nsorted was for as I couldn't tell from the
comments.

Author: Ranier Vilela
Discussion: https://postgr.es/m/CAEudQAqJQzPitufX-jR=YUbJafpCDAKUnwgdbX_MzSc93wuvdw@mail.gmail.com
Backpatch-through: 14, where multi-range brin was added.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c2aa5d01e3e33776f77e68a60ca5b60b58c5c674

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 172 ++++++++++++++--------------
1 file changed, 88 insertions(+), 84 deletions(-)



view thread (3+ messages)

Message-ID: <E1oXsUl-0004dK-Ls@gemulon.postgresql.org>
Permalink:  ../E1oXsUl-0004dK-Ls@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oXsUl-0004dK-Ls@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Don't reference out-of-bounds array elements in brin_minmax_mult
  In-Reply-To: <E1oXsUl-0004dK-Ls@gemulon.postgresql.org>
  References: <E1oXsUl-0004dK-Ls@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox