pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't reflect unescaped cert data to the logs
Date: Tue, 13 Sep 2022 14:11:08 +0000
Message-ID: <E1oY6d2-000AWh-48@gemulon.postgresql.org> (raw)

Don't reflect unescaped cert data to the logs

Commit 3a0e385048 introduced a new path for unauthenticated bytes from
the client certificate to be printed unescaped to the logs. There are a
handful of these already, but it doesn't make sense to keep making the
problem worse. \x-escape any unprintable bytes.

The test case introduces a revoked UTF-8 certificate. This requires the
addition of the `-utf8` flag to `openssl req`. Since the existing
certificates all use an ASCII subset, this won't modify the existing
certificates' subjects if/when they get regenerated; this was verified
experimentally with

    $ make sslfiles-clean
    $ make sslfiles

Unfortunately the test can't be run in the CI yet due to a test timing
issue; see 55828a6b60.

Author: Jacob Champion <jchampion@timescale.com>
Discussion: https://www.postgresql.org/message-id/CAAWbhmgsvHrH9wLU2kYc3pOi1KSenHSLAHBbCVmmddW6-mc_=w@mail.gmail...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/257eb57b50f7c65467bfc2f4d579622fa13f3370

Modified Files
--------------
src/backend/libpq/be-secure-openssl.c           | 57 ++++++++++++++-----------
src/test/ssl/conf/client-revoked-utf8.config    | 13 ++++++
src/test/ssl/ssl/client-crldir/9bb9e3c3.r0      | 19 +++++----
src/test/ssl/ssl/client-revoked-utf8.crt        | 18 ++++++++
src/test/ssl/ssl/client-revoked-utf8.key        | 27 ++++++++++++
src/test/ssl/ssl/client.crl                     | 19 +++++----
src/test/ssl/ssl/root+client-crldir/9bb9e3c3.r0 | 19 +++++----
src/test/ssl/ssl/root+client.crl                | 19 +++++----
src/test/ssl/sslfiles.mk                        | 10 +++--
src/test/ssl/t/001_ssltests.pl                  | 13 ++++++
src/test/ssl/t/SSL/Backend/OpenSSL.pm           |  3 +-
11 files changed, 150 insertions(+), 67 deletions(-)



Message-ID: <E1oY6d2-000AWh-48@gemulon.postgresql.org>
Permalink:  ../E1oY6d2-000AWh-48@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oY6d2-000AWh-48@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Don't reflect unescaped cert data to the logs
  In-Reply-To: <E1oY6d2-000AWh-48@gemulon.postgresql.org>
  References: <E1oY6d2-000AWh-48@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox