pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect value for "strategy" with deflateParams() in walme
Date: Wed, 14 Sep 2022 05:52:51 +0000
Message-ID: <E1oYLKN-000GQC-49@gemulon.postgresql.org> (raw)

Fix incorrect value for "strategy" with deflateParams() in walmethods.c

The zlib documentation mentions the values supported for the compression
strategy, but this code has been using a hardcoded value of 0 rather
than Z_DEFAULT_STRATEGY.  This commit adjusts the code to use
Z_DEFAULT_STRATEGY.

Backpatch down to where this code has been added to ease the backport of
any future patch touching this area.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/1400032.1662217889@sss.pgh.pa.us
Backpatch-through: 10

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4b529f4697f3cb59e1a225a741f14a1afb6bccd5

Modified Files
--------------
src/bin/pg_basebackup/walmethods.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oYLKN-000GQC-49@gemulon.postgresql.org>
Permalink:  ../E1oYLKN-000GQC-49@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oYLKN-000GQC-49@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix incorrect value for "strategy" with deflateParams() in walme
  In-Reply-To: <E1oYLKN-000GQC-49@gemulon.postgresql.org>
  References: <E1oYLKN-000GQC-49@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox