pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert ill-considered change in pg_resetwal output.
Date: Thu, 15 Sep 2022 14:58:11 +0000
Message-ID: <E1oYqJe-000TAz-N5@gemulon.postgresql.org> (raw)

Revert ill-considered change in pg_resetwal output.

Commit 31dcfae83 changed one pg_resetwal output string, and a
corresponding test in pg_upgrade, without sufficient thought for
the consequences.  We can't change that output without creating
hazards for cross-version upgrades, since pg_upgrade needs to be able
to read the output of several different versions of pg_resetwal.
There may well be external tools with the same requirement.

For the moment, just revert those two changes.  What we really
ought to do here is have a separate, stable, easily machine-readable
output format for pg_resetwal and pg_controldata, as proposed
years ago by Alvaro.  Once that's in place and tools no longer
need to depend on the exact spelling of the human-readable output,
we can put back this change.

Discussion: https://postgr.es/m/fbea8c6f-415a-bad9-c3de-969c40d08a84@dunslane.net

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/918de37652138da7f7e54c79351178367d60f501

Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c | 2 +-
src/bin/pg_upgrade/controldata.c  | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1oYqJe-000TAz-N5@gemulon.postgresql.org>
Permalink:  ../E1oYqJe-000TAz-N5@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oYqJe-000TAz-N5@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Revert ill-considered change in pg_resetwal output.
  In-Reply-To: <E1oYqJe-000TAz-N5@gemulon.postgresql.org>
  References: <E1oYqJe-000TAz-N5@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox