From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix race condition in stats.sql added in 5264add7847
Date: Fri, 16 Sep 2022 18:31:35 +0000
Message-ID: <E1oZG7j-000dmS-Ei@gemulon.postgresql.org> (raw)
Fix race condition in stats.sql added in 5264add7847
Very occasionally the stats test failed due to the number of sessions not
being updated yet. Likely this requires that there is contention on the
database's stats entry. Solve this by forcing pending stats to be flushed
before fetching the stats.
I verified that there are no other test failures after making
pgstat_report_stat() only flush stats when force = true.
Per message from Tom Lane and buildfarm member crake.
Discussion: https://postgr.es/m/3428246.1663271992@sss.pgh.pa.us
Backpatch: 15-, where 5264add7847 added the test
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/885826f95d1c7803d3ff97bde64078b257543266
Modified Files
--------------
src/test/regress/expected/stats.out | 6 ++++++
src/test/regress/sql/stats.sql | 1 +
2 files changed, 7 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: Fix race condition in stats.sql added in 5264add7847
In-Reply-To: <E1oZG7j-000dmS-Ei@gemulon.postgresql.org>
References: <E1oZG7j-000dmS-Ei@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox