pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c
Date: Sat, 17 Sep 2022 16:56:56 +0000
Message-ID: <E1oZb7g-000m9d-5U@gemulon.postgresql.org> (raw)

Include c.h instead of postgres.h in src/port/*p{read,write}*.c

Frontend code shouldn't include postgres.h. Some files in src/port/ need to
include postgres.h/postgres_fe.h, but these files don't.

Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw5mq@awork3.anarazel.de
Backpatch: 12-, where 3fd2a7932ef introduced (some) of these files

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/43fcaa345d5af45101c5d96dd164f1ebed686b2c

Modified Files
--------------
src/port/preadv.c      | 2 +-
src/port/pwritev.c     | 2 +-
src/port/win32pread.c  | 2 +-
src/port/win32pwrite.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1oZb7g-000m9d-5U@gemulon.postgresql.org>
Permalink:  ../E1oZb7g-000m9d-5U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oZb7g-000m9d-5U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c
  In-Reply-To: <E1oZb7g-000m9d-5U@gemulon.postgresql.org>
  References: <E1oZb7g-000m9d-5U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox