pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harmonize reorderbuffer parameter names.
Date: Sun, 18 Sep 2022 00:21:23 +0000
Message-ID: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org> (raw)

Harmonize reorderbuffer parameter names.

Make reorderbuffer.h function declarations consistently use named
parameters.  Also make sure that the declarations use names that match
corresponding names from function definitions in reorderbuffer.c.  This
makes the definitions easier to follow, especially in the case of
functions that happen to have adjoining arguments of the same type.

This patch was written with help from clang-tidy.  Specifically, its
"readability-inconsistent-declaration-parameter-name" check and its
"readability-named-parameter" check were used.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/3955318.1663377656@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/035ce1feb2ed27680558ebc5cd1455041c8ec3cf

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c |  6 +--
src/include/replication/reorderbuffer.h         | 72 ++++++++++++++-----------
2 files changed, 43 insertions(+), 35 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org>
Permalink:  ../E1oZi3m-000pD8-Gb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oZi3m-000pD8-Gb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
  In-Reply-To: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org>
  References: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox