From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Consistently use named parameters in regex code.
Date: Mon, 19 Sep 2022 22:11:40 +0000
Message-ID: <E1oaOzL-0016XZ-NN@gemulon.postgresql.org> (raw)
Consistently use named parameters in regex code.
Make regex code consistently use named parameters in function
declarations. Also make sure that parameter names from each function's
declaration match corresponding definition parameter names.
This makes Henry Spencer's regex code follow Postgres coding standards.
Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bc2187ed63c56bb9cd99f6613f3e2ba56afb22fe
Modified Files
--------------
src/backend/regex/regcomp.c | 342 +++++++++++++++++--------------
src/backend/regex/regexec.c | 65 +++---
src/backend/utils/adt/regexp.c | 2 +-
src/include/regex/regex.h | 14 +-
src/test/modules/test_regex/test_regex.c | 2 +-
5 files changed, 241 insertions(+), 184 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie
Subject: Re: pgsql: Consistently use named parameters in regex code.
In-Reply-To: <E1oaOzL-0016XZ-NN@gemulon.postgresql.org>
References: <E1oaOzL-0016XZ-NN@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox