pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Consistently use named parameters in timezone code.
Date: Mon, 19 Sep 2022 22:15:07 +0000
Message-ID: <E1oaP2g-0016ay-Uy@gemulon.postgresql.org> (raw)

Consistently use named parameters in timezone code.

Make our copy of the IANA timezone library use named parameters in
function declarations.  Also make sure that parameter names from each
function's declaration match corresponding definition parameter names.

This makes the timezone code follow Postgres coding standards.  The
value of having a consistent standard everywhere seems to outweigh the
cost of keeping the function declarations in sync with future IANA
releases.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c4f8e89fef3d4cd8b0791637667fd984d6f38fb2

Modified Files
--------------
src/timezone/localtime.c | 16 +++++++++-------
src/timezone/pgtz.c      |  8 ++++----
src/timezone/strftime.c  | 10 +++++-----
src/timezone/zic.c       | 34 ++++++++++++++++++----------------
4 files changed, 36 insertions(+), 32 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1oaP2g-0016ay-Uy@gemulon.postgresql.org>
Permalink:  ../E1oaP2g-0016ay-Uy@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oaP2g-0016ay-Uy@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Consistently use named parameters in timezone code.
  In-Reply-To: <E1oaP2g-0016ay-Uy@gemulon.postgresql.org>
  References: <E1oaP2g-0016ay-Uy@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox