From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Extend gendef.pl in preparation for meson
Date: Mon, 19 Sep 2022 22:42:03 +0000
Message-ID: <E1oaPSl-0016nh-1N@gemulon.postgresql.org> (raw)
Extend gendef.pl in preparation for meson
The main issue with using gendef.pl as-is for meson is that with meson the
filenames are a bit longer, exceeding the max commandline length when calling
dumpbin with all objects. As it's easier to pass in a library anyway, do so.
The .def file location, input and temporary file location need to be tunable
as well.
This also fixes a bug in gendef.pl: The logic when to regenerate was broken
and never avoid regenerating.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/20220809071055.rgikv3qn74ypnnbb@awork3.anarazel.de
Discussion: https://postgr.es/m/7dae5979-c6c0-cec5-7a36-76a85aa8053d@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/70df2df1cc89e69e31b31b6aa0d65fd72935af38
Modified Files
--------------
src/tools/msvc/MSBuildProject.pm | 4 ++-
src/tools/msvc/gendef.pl | 67 +++++++++++++++++++++++++++-------------
2 files changed, 49 insertions(+), 22 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: Extend gendef.pl in preparation for meson
In-Reply-To: <E1oaPSl-0016nh-1N@gemulon.postgresql.org>
References: <E1oaPSl-0016nh-1N@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox