pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harmonize heapam and tableam parameter names.
Date: Mon, 19 Sep 2022 23:47:06 +0000
Message-ID: <E1oaQTi-0017GK-9n@gemulon.postgresql.org> (raw)

Harmonize heapam and tableam parameter names.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions.  Having parameter names
that are reliably consistent in this way will make it easier to reason
about groups of related C functions from the same translation unit as a
module.  It will also make certain refactoring tasks easier.

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.  Later commits will do the
same for other parts of the codebase.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4bac9600f09a9b9ba7daa3ba69495a877f51e6c3

Modified Files
--------------
src/backend/access/common/heaptuple.c       | 14 ++++----
src/backend/access/heap/heapam.c            |  2 +-
src/backend/access/heap/heapam_visibility.c | 16 ++++-----
src/backend/access/heap/visibilitymap.c     | 56 ++++++++++++++---------------
src/backend/access/table/tableam.c          | 11 +++---
src/backend/access/transam/multixact.c      |  6 ++--
src/include/access/heapam.h                 | 26 +++++++-------
src/include/access/heapam_xlog.h            |  4 +--
src/include/access/htup_details.h           |  2 +-
src/include/access/multixact.h              |  7 ++--
src/include/access/rewriteheap.h            | 12 +++----
src/include/access/tableam.h                |  8 ++---
src/include/commands/cluster.h              |  2 +-
src/include/replication/snapbuild.h         | 13 +++----
14 files changed, 90 insertions(+), 89 deletions(-)



Message-ID: <E1oaQTi-0017GK-9n@gemulon.postgresql.org>
Permalink:  ../E1oaQTi-0017GK-9n@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oaQTi-0017GK-9n@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Harmonize heapam and tableam parameter names.
  In-Reply-To: <E1oaQTi-0017GK-9n@gemulon.postgresql.org>
  References: <E1oaQTi-0017GK-9n@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox