pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix `trap` in a few shell scripts
Date: Tue, 20 Sep 2022 17:05:12 +0000
Message-ID: <E1oaggJ-001Dnx-Mb@gemulon.postgresql.org> (raw)

Fix `trap` in a few shell scripts

The original `trap` lines in these scripts are incomplete: in case of
any signal, they delete the working directory but let the script run to
completion, which is useless because it will only proceed to complain
about the working directory being removed.  Add `exit` there, with the
original exit value (not rm's).

Since this is mostly just cosmetic, no backpatch.

Discussion: https://postgr.es/m/20220913181002.hzsosy7qkemb7ky7@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3d53b9ef1a4cda7b6303a0496f8531eceeef0e77

Modified Files
--------------
src/tools/find_static              | 2 +-
src/tools/make_ctags               | 2 +-
src/tools/pginclude/cpluspluscheck | 2 +-
src/tools/pginclude/headerscheck   | 6 +++---
src/tools/pgtest                   | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)



Message-ID: <E1oaggJ-001Dnx-Mb@gemulon.postgresql.org>
Permalink:  ../E1oaggJ-001Dnx-Mb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oaggJ-001Dnx-Mb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Fix `trap` in a few shell scripts
  In-Reply-To: <E1oaggJ-001Dnx-Mb@gemulon.postgresql.org>
  References: <E1oaggJ-001Dnx-Mb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox