pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tighten pg_get_object_address argument checking
Date: Wed, 21 Sep 2022 13:54:51 +0000
Message-ID: <E1ob0Bf-001Lsn-Dv@gemulon.postgresql.org> (raw)

Tighten pg_get_object_address argument checking

For publication schemas (OBJECT_PUBLICATION_NAMESPACE) and user
mappings (OBJECT_USER_MAPPING), pg_get_object_address() checked the
array length of the second argument, but not of the first argument.
If the first argument was too long, it would just silently ignore
everything but the first argument.  Fix that by checking the length of
the first argument as well.

Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/caaef70b-a874-1088-92ef-5ac38269c33b%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2da8c4cff39328897aa716a0ba57bdada5aeaf6e

Modified Files
--------------
src/backend/catalog/objectaddress.c          | 10 ++++++++--
src/test/regress/expected/object_address.out | 16 +++++++++++-----
src/test/regress/sql/object_address.sql      |  2 +-
3 files changed, 20 insertions(+), 8 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1ob0Bf-001Lsn-Dv@gemulon.postgresql.org>
Permalink:  ../E1ob0Bf-001Lsn-Dv@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ob0Bf-001Lsn-Dv@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Tighten pg_get_object_address argument checking
  In-Reply-To: <E1ob0Bf-001Lsn-Dv@gemulon.postgresql.org>
  References: <E1ob0Bf-001Lsn-Dv@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox