pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harmonize parameter names in ecpg code.
Date: Thu, 22 Sep 2022 19:54:05 +0000
Message-ID: <E1obSGr-001YDO-0i@gemulon.postgresql.org> (raw)

Harmonize parameter names in ecpg code.

Make ecpg function declarations consistently use named parameters.  Also
make sure that the declarations use names that match corresponding names
from function definitions.

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3535ebce5dc542b90f14d6e81cce80fe7226bda5

Modified Files
--------------
src/interfaces/ecpg/ecpglib/ecpglib_extern.h       | 78 ++++++++++++--------
src/interfaces/ecpg/include/ecpg_informix.h        | 82 +++++++++++-----------
src/interfaces/ecpg/include/ecpglib.h              | 60 +++++++++-------
src/interfaces/ecpg/include/pgtypes_date.h         | 20 +++---
src/interfaces/ecpg/include/pgtypes_interval.h     |  8 +--
src/interfaces/ecpg/include/pgtypes_numeric.h      | 36 +++++-----
src/interfaces/ecpg/include/pgtypes_timestamp.h    | 12 ++--
src/interfaces/ecpg/pgtypeslib/dt.h                | 22 +++---
src/interfaces/ecpg/pgtypeslib/pgtypeslib_extern.h |  8 ++-
src/interfaces/ecpg/preproc/c_keywords.c           |  8 +--
src/interfaces/ecpg/preproc/ecpg.header            |  2 +-
src/interfaces/ecpg/preproc/output.c               |  2 +-
src/interfaces/ecpg/preproc/pgc.l                  |  2 +-
src/interfaces/ecpg/preproc/preproc_extern.h       | 63 ++++++++++-------
src/interfaces/ecpg/preproc/type.c                 |  2 +-
src/interfaces/ecpg/preproc/type.h                 | 27 ++++---
.../ecpg/test/expected/preproc-outofscope.c        | 36 +++++-----
src/interfaces/ecpg/test/expected/sql-sqlda.c      | 36 +++++-----
18 files changed, 271 insertions(+), 233 deletions(-)



Message-ID: <E1obSGr-001YDO-0i@gemulon.postgresql.org>
Permalink:  ../E1obSGr-001YDO-0i@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1obSGr-001YDO-0i@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Harmonize parameter names in ecpg code.
  In-Reply-To: <E1obSGr-001YDO-0i@gemulon.postgresql.org>
  References: <E1obSGr-001YDO-0i@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox