pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harmonize parameter names in pg_dump/pg_dumpall.
Date: Thu, 22 Sep 2022 23:42:11 +0000
Message-ID: <E1obVpa-001Zkf-Nk@gemulon.postgresql.org> (raw)

Harmonize parameter names in pg_dump/pg_dumpall.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in pg_dump/pg_dumpall
related code.

Affected code happens to be inconsistent in how it applies conventions
around how Archive and Archive Handle variables are named.  Significant
code churn is required to fully fix those inconsistencies, so take the
least invasive approach possible: treat function definition names as
authoritative, and mechanically adjust corresponding names from function
definitions to match.

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAH2-Wzmma+vzcO6gr5NYDZ+sx0G14aU-UrzFutT2FoRaisVCUQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/20e69daa1348f6899fffe3c260bf44293551ee87

Modified Files
--------------
src/bin/pg_dump/common.c              |  2 +-
src/bin/pg_dump/pg_backup.h           | 14 +++++++-------
src/bin/pg_dump/pg_backup_archiver.h  |  2 +-
src/bin/pg_dump/pg_backup_custom.c    |  2 +-
src/bin/pg_dump/pg_backup_directory.c |  2 +-
src/bin/pg_dump/pg_backup_tar.c       |  4 ++--
src/bin/pg_dump/pg_dump.c             |  8 ++++----
src/bin/pg_dump/pg_dump.h             |  6 +++---
src/bin/pg_dump/pg_dumpall.c          |  6 ++++--
9 files changed, 24 insertions(+), 22 deletions(-)



Message-ID: <E1obVpa-001Zkf-Nk@gemulon.postgresql.org>
Permalink:  ../E1obVpa-001Zkf-Nk@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1obVpa-001Zkf-Nk@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Harmonize parameter names in pg_dump/pg_dumpall.
  In-Reply-To: <E1obVpa-001Zkf-Nk@gemulon.postgresql.org>
  References: <E1obVpa-001Zkf-Nk@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox