From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stop using PQsendQuery in libpq_pipeline
Date: Fri, 23 Sep 2022 16:12:42 +0000
Message-ID: <E1oblI9-001g0o-TH@gemulon.postgresql.org> (raw)
Stop using PQsendQuery in libpq_pipeline
The "emulation" I wrote for PQsendQuery in pipeline mode to use extended
query protocol, in commit acb7e4eb6b1c, is problematic. Due to numerous
bugs we'll soon remove it. As a first step and for all branches back to
14, stop using PQsendQuery in libpq_pipeline. Also remove a few test
lines that will no longer be relevant.
Backpatch to 14.
Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/1c03166352c3fd94dd131938e42f2a182fcf4067
Modified Files
--------------
src/test/modules/libpq_pipeline/libpq_pipeline.c | 138 ++-------------------
.../libpq_pipeline/traces/pipeline_abort.trace | 6 +-
.../libpq_pipeline/traces/pipeline_idle.trace | 67 +---------
3 files changed, 13 insertions(+), 198 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: Stop using PQsendQuery in libpq_pipeline
In-Reply-To: <E1oblI9-001g0o-TH@gemulon.postgresql.org>
References: <E1oblI9-001g0o-TH@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox