From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove PQsendQuery support in pipeline mode
Date: Fri, 23 Sep 2022 16:24:34 +0000
Message-ID: <E1oblTe-001g68-6a@gemulon.postgresql.org> (raw)
Remove PQsendQuery support in pipeline mode
The extended query protocol implementation I added in commit
acb7e4eb6b1c has bugs when used in pipeline mode. Rather than spend
more time trying to fix it, remove that code and make the function rely
on simple query protocol only, meaning it can no longer be used in
pipeline mode.
Users can easily change their applications to use PQsendQueryParams
instead. We leave PQsendQuery in place for Postgres 14, just in case
somebody is using it and has not hit the mentioned bugs; but we should
recommend that it not be used.
Backpatch to 15.
Per bug report from Gabriele Varrazzo.
Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bd8ac900df4d2824f50ce4b1674754685aeaed56
Modified Files
--------------
doc/src/sgml/libpq.sgml | 9 +-
src/interfaces/libpq/fe-exec.c | 117 +++++------------------
src/interfaces/libpq/fe-protocol3.c | 18 +---
src/test/modules/libpq_pipeline/libpq_pipeline.c | 12 +++
4 files changed, 41 insertions(+), 115 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: Remove PQsendQuery support in pipeline mode
In-Reply-To: <E1oblTe-001g68-6a@gemulon.postgresql.org>
References: <E1oblTe-001g68-6a@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox