pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove PQsendQuery support in pipeline mode 2+ messages / 1 participants [nested] [flat]
* pgsql: Remove PQsendQuery support in pipeline mode @ 2022-09-23 16:24 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2022-09-23 16:24 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove PQsendQuery support in pipeline mode The extended query protocol implementation I added in commit acb7e4eb6b1c has bugs when used in pipeline mode. Rather than spend more time trying to fix it, remove that code and make the function rely on simple query protocol only, meaning it can no longer be used in pipeline mode. Users can easily change their applications to use PQsendQueryParams instead. We leave PQsendQuery in place for Postgres 14, just in case somebody is using it and has not hit the mentioned bugs; but we should recommend that it not be used. Backpatch to 15. Per bug report from Gabriele Varrazzo. Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0032a5456708811ca95bd80a538f4fb72ad0dd20 Modified Files -------------- doc/src/sgml/libpq.sgml | 9 +- src/interfaces/libpq/fe-exec.c | 117 +++++------------------ src/interfaces/libpq/fe-protocol3.c | 18 +--- src/test/modules/libpq_pipeline/libpq_pipeline.c | 12 +++ 4 files changed, 41 insertions(+), 115 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove PQsendQuery support in pipeline mode @ 2022-09-23 16:24 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2022-09-23 16:24 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove PQsendQuery support in pipeline mode The extended query protocol implementation I added in commit acb7e4eb6b1c has bugs when used in pipeline mode. Rather than spend more time trying to fix it, remove that code and make the function rely on simple query protocol only, meaning it can no longer be used in pipeline mode. Users can easily change their applications to use PQsendQueryParams instead. We leave PQsendQuery in place for Postgres 14, just in case somebody is using it and has not hit the mentioned bugs; but we should recommend that it not be used. Backpatch to 15. Per bug report from Gabriele Varrazzo. Discussion: https://postgr.es/m/CA+mi_8ZGSQNmW6-mk_iSR4JZB_LJ4ww3suOF+1vGNs3MrLsv4g@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bd8ac900df4d2824f50ce4b1674754685aeaed56 Modified Files -------------- doc/src/sgml/libpq.sgml | 9 +- src/interfaces/libpq/fe-exec.c | 117 +++++------------------ src/interfaces/libpq/fe-protocol3.c | 18 +--- src/test/modules/libpq_pipeline/libpq_pipeline.c | 12 +++ 4 files changed, 41 insertions(+), 115 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-09-23 16:24 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-09-23 16:24 pgsql: Remove PQsendQuery support in pipeline mode Alvaro Herrera <alvherre@alvh.no-ip.org> 2022-09-23 16:24 pgsql: Remove PQsendQuery support in pipeline mode Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox