pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix reading of BitString nodes
Date: Sat, 24 Sep 2022 22:29:27 +0000
Message-ID: <E1ocDeJ-001rN3-0V@gemulon.postgresql.org> (raw)

Fix reading of BitString nodes

The node tokenizer went out of its way to store BitString node values
without the leading 'b'.  But everything else in the system stores the
leading 'b'.  This would break if a BitString node is
read-printed-read.

Also, the node tokenizer didn't know that BitString node tokens could
also start with 'x'.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/4159834.1657405226@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2cb1a5a8d4aeb63da2d6a2d22169f05c60bb5828

Modified Files
--------------
src/backend/nodes/read.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)



Message-ID: <E1ocDeJ-001rN3-0V@gemulon.postgresql.org>
Permalink:  ../E1ocDeJ-001rN3-0V@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ocDeJ-001rN3-0V@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Fix reading of BitString nodes
  In-Reply-To: <E1ocDeJ-001rN3-0V@gemulon.postgresql.org>
  References: <E1ocDeJ-001rN3-0V@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox