pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert 56-bit relfilenode change and follow-up commits.
Date: Wed, 28 Sep 2022 13:55:46 +0000
Message-ID: <E1odXXO-002Olv-7E@gemulon.postgresql.org> (raw)

Revert 56-bit relfilenode change and follow-up commits.

There are still some alignment-related failures in the buildfarm,
which might or might not be able to be fixed quickly, but I've also
just realized that it increased the size of many WAL records by 4 bytes
because a block reference contains a RelFileLocator. The effect of that
hasn't been studied or discussed, so revert for now.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a448e49bcbe40fb72e1ed85af910dd216d45bad8

Modified Files
--------------
contrib/pg_buffercache/Makefile                    |   4 +-
contrib/pg_buffercache/meson.build                 |   1 -
.../pg_buffercache/pg_buffercache--1.3--1.4.sql    |  30 ---
contrib/pg_buffercache/pg_buffercache.control      |   2 +-
contrib/pg_buffercache/pg_buffercache_pages.c      |  39 +---
contrib/pg_prewarm/autoprewarm.c                   |   4 +-
contrib/pg_walinspect/expected/pg_walinspect.out   |   4 +-
contrib/pg_walinspect/sql/pg_walinspect.sql        |   4 +-
doc/src/sgml/catalogs.sgml                         |   2 +-
doc/src/sgml/func.sgml                             |   5 -
doc/src/sgml/pgbuffercache.sgml                    |   2 +-
doc/src/sgml/storage.sgml                          |  11 +-
src/backend/access/gin/ginxlog.c                   |   2 +-
src/backend/access/rmgrdesc/gistdesc.c             |   2 +-
src/backend/access/rmgrdesc/heapdesc.c             |   2 +-
src/backend/access/rmgrdesc/nbtdesc.c              |   2 +-
src/backend/access/rmgrdesc/seqdesc.c              |   2 +-
src/backend/access/rmgrdesc/xlogdesc.c             |  21 +--
src/backend/access/transam/README                  |   5 +-
src/backend/access/transam/varsup.c                | 209 +--------------------
src/backend/access/transam/xlog.c                  |  60 ------
src/backend/access/transam/xlogprefetcher.c        |  14 +-
src/backend/access/transam/xlogrecovery.c          |   6 +-
src/backend/access/transam/xlogutils.c             |   6 +-
src/backend/backup/basebackup.c                    |   2 +-
src/backend/catalog/catalog.c                      |  95 ++++++++++
src/backend/catalog/heap.c                         |  27 ++-
src/backend/catalog/index.c                        |  11 +-
src/backend/catalog/storage.c                      |   8 -
src/backend/commands/tablecmds.c                   |  12 +-
src/backend/commands/tablespace.c                  |   2 +-
src/backend/nodes/gen_node_support.pl              |   4 +-
src/backend/replication/logical/decode.c           |   1 -
src/backend/replication/logical/reorderbuffer.c    |   2 +-
src/backend/storage/file/reinit.c                  |  28 +--
src/backend/storage/freespace/fsmpage.c            |   2 +-
src/backend/storage/lmgr/lwlocknames.txt           |   1 -
src/backend/storage/smgr/md.c                      |   7 -
src/backend/storage/smgr/smgr.c                    |   2 +-
src/backend/utils/adt/dbsize.c                     |   7 +-
src/backend/utils/adt/pg_upgrade_support.c         |  13 +-
src/backend/utils/cache/inval.c                    |   9 +-
src/backend/utils/cache/relcache.c                 |   2 +-
src/backend/utils/cache/relfilenumbermap.c         |  28 ++-
src/backend/utils/misc/pg_controldata.c            |   9 +-
src/bin/pg_checksums/pg_checksums.c                |   4 +-
src/bin/pg_controldata/pg_controldata.c            |   2 -
src/bin/pg_dump/pg_dump.c                          |  26 +--
src/bin/pg_rewind/filemap.c                        |   6 +-
src/bin/pg_upgrade/info.c                          |   3 +-
src/bin/pg_upgrade/pg_upgrade.c                    |   6 +-
src/bin/pg_upgrade/relfilenumber.c                 |   4 +-
src/bin/pg_waldump/pg_waldump.c                    |   2 +-
src/bin/scripts/t/090_reindexdb.pl                 |   2 +-
src/common/relpath.c                               |  20 +-
src/fe_utils/option_utils.c                        |  40 ----
src/include/access/transam.h                       |  40 ----
src/include/access/xlog.h                          |   1 -
src/include/catalog/catalog.h                      |   3 +
src/include/catalog/catversion.h                   |   2 +-
src/include/catalog/pg_class.h                     |  16 +-
src/include/catalog/pg_control.h                   |   2 -
src/include/catalog/pg_proc.dat                    |  10 +-
src/include/common/relpath.h                       |   7 +-
src/include/fe_utils/option_utils.h                |   2 -
src/include/storage/buf_internals.h                |  55 +-----
src/include/storage/relfilelocator.h               |  12 +-
src/include/storage/sinval.h                       |   7 +-
src/test/regress/expected/alter_table.out          |  24 +--
src/test/regress/expected/fast_default.out         |   4 +-
src/test/regress/expected/oidjoins.out             |   2 +-
src/test/regress/sql/alter_table.sql               |   8 +-
src/test/regress/sql/fast_default.sql              |   4 +-
73 files changed, 305 insertions(+), 720 deletions(-)



Message-ID: <E1odXXO-002Olv-7E@gemulon.postgresql.org>
Permalink:  ../E1odXXO-002Olv-7E@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1odXXO-002Olv-7E@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Revert 56-bit relfilenode change and follow-up commits.
  In-Reply-To: <E1odXXO-002Olv-7E@gemulon.postgresql.org>
  References: <E1odXXO-002Olv-7E@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox