pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Change some errdetail() to errdetail_internal()
Date: Wed, 28 Sep 2022 15:19:36 +0000
Message-ID: <E1odYqV-002PMJ-MO@gemulon.postgresql.org> (raw)

Change some errdetail() to errdetail_internal()

This prevents marking the argument string for translation for gettext,
and it also prevents the given string (which is already translated) from
being translated at runtime.

Also, mark the strings used as arguments to check_rolespec_name for
translation.

Backpatch all the way back as appropriate.  None of this is caught by
any tests (necessarily so), so I verified it manually.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d84a7b290f866b3f16cbefb0fca31b69ebace98a

Modified Files
--------------
src/backend/catalog/dependency.c       | 6 +++---
src/backend/commands/publicationcmds.c | 2 +-
src/backend/commands/user.c            | 4 ++--
src/backend/utils/adt/acl.c            | 4 ++--
src/backend/utils/adt/jsonfuncs.c      | 4 ++--
src/common/jsonapi.c                   | 4 ++--
6 files changed, 12 insertions(+), 12 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1odYqV-002PMJ-MO@gemulon.postgresql.org>
Permalink:  ../E1odYqV-002PMJ-MO@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1odYqV-002PMJ-MO@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Change some errdetail() to errdetail_internal()
  In-Reply-To: <E1odYqV-002PMJ-MO@gemulon.postgresql.org>
  References: <E1odYqV-002PMJ-MO@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox