pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve wording of log messages triggered by max_slot_wal_keep_s
Date: Thu, 29 Sep 2022 17:28:00 +0000
Message-ID: <E1odxKK-000ADq-3U@gemulon.postgresql.org> (raw)

Improve wording of log messages triggered by max_slot_wal_keep_size.

The one about "terminating process to release replication slot" told
you nothing about why that was happening.  The one about "invalidating
slot because its restart_lsn exceeds max_slot_wal_keep_size" told you
what was happening, but violated our message style guideline about
keeping the primary message short.  Add DETAIL/HINT lines to carry
the appropriate detail and make the two cases more uniform.

While here, fix bogus test logic in 019_replslot_limit.pl: if it timed
out without seeing the expected log message, no test failure would be
reported.  This is flat broken since commit 549ec201d removed the test
counts; even before that it was horribly bad style, since you'd only
get told that not all tests had been run.

Kyotaro Horiguchi, reviewed by Bertrand Drouvot; test fixes by me

Discussion: https://postgr.es/m/20211214.130456.2233153190058148084.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/551aa6b7b9f3b78e7b6cbab1fea70947fa7f4966

Modified Files
--------------
src/backend/replication/slot.c            | 17 ++++++++++++-----
src/test/recovery/t/019_replslot_limit.pl | 15 +++++++++------
2 files changed, 21 insertions(+), 11 deletions(-)



Message-ID: <E1odxKK-000ADq-3U@gemulon.postgresql.org>
Permalink:  ../E1odxKK-000ADq-3U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1odxKK-000ADq-3U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Improve wording of log messages triggered by max_slot_wal_keep_s
  In-Reply-To: <E1odxKK-000ADq-3U@gemulon.postgresql.org>
  References: <E1odxKK-000ADq-3U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox