From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute().
Date: Fri, 30 Sep 2022 14:26:53 +0000
Message-ID: <E1oeGya-000IWI-Q5@gemulon.postgresql.org> (raw)
Adjust PQsslAttributeNames() to match PQsslAttribute().
Currently, PQsslAttributeNames() returns the same list of attribute
names regardless of its conn parameter. This patch changes it to
have behavior parallel to what 80a05679d installed for PQsslAttribute:
you get OpenSSL's attributes if conn is NULL or is an SSL-encrypted
connection, or an empty list if conn is a non-encrypted connection.
The point of this is to have sensible connection-dependent behavior
in case we ever support multiple SSL libraries. The behavior for
NULL can be defined as "the attributes for the default SSL library",
parallel to what PQsslAttribute(NULL, "library") does.
Since this is mostly just future-proofing, no back-patch.
Discussion: https://postgr.es/m/17625-fc47c78b7d71b534@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4e4f7b9fcc9ad0b023b6e698e978882d022b94c4
Modified Files
--------------
doc/src/sgml/libpq.sgml | 12 +++++++++++-
src/interfaces/libpq/fe-secure-openssl.c | 15 +++++++++++++--
2 files changed, 24 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute().
In-Reply-To: <E1oeGya-000IWI-Q5@gemulon.postgresql.org>
References: <E1oeGya-000IWI-Q5@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox