pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for
Date: Fri, 30 Sep 2022 17:50:41 +0000
Message-ID: <E1oeK9o-000Jn2-TZ@gemulon.postgresql.org> (raw)

mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for msvc

While mingw would otherwise fall back to
__attribute__((visibility("default"))), that appears to only work as long as
no symbols are declared with __declspec(dllexport). But we can end up with
some, e.g. plpython's Py_Init.

It's quite possible we should do the same for cygwin, but I don't have a test
environment for that...

Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de
Discussion: http://postgr.es/m/20220928025242.ugf7t5ugxxgmkraa@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0e497eadb1f4028b147b5c58dc08cea7e73675e1

Modified Files
--------------
src/include/port/win32.h | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)



Message-ID: <E1oeK9o-000Jn2-TZ@gemulon.postgresql.org>
Permalink:  ../E1oeK9o-000Jn2-TZ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oeK9o-000Jn2-TZ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for
  In-Reply-To: <E1oeK9o-000Jn2-TZ@gemulon.postgresql.org>
  References: <E1oeK9o-000Jn2-TZ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox