pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix psql's behavior with \g for a multiple-command string. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix psql's behavior with \g for a multiple-command string. @ 2022-10-03 19:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-10-03 19:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix psql's behavior with \g for a multiple-command string. The pre-v15 behavior was to discard all but the last result, but with the new behavior of printing all results by default, we will send each such result to the \g file. However, we're still opening and closing the \g file for each result, so you lose all but the last result anyway. Move the output-file state up to ExecQueryAndProcessResults so that we open/close the \g file only once per command string. To support this without changing other behavior, we must adjust PrintQueryResult to have separate FILE * arguments for query and status output (since status output has never gone to the \g file). That in turn makes it a good idea to push the responsibility for fflush'ing output down to PrintQueryTuples and PrintQueryStatus. Also fix an infinite loop if COPY IN/OUT is attempted in \watch. We used to reject that, but that error exit path got broken somewhere along the line in v15. There seems no real reason to reject it anyway as the code now stands, so just remove the error exit and make sure that COPY OUT data goes to the right place. Also remove PrintQueryResult's unused is_watch parameter, and make some other cosmetic cleanups (adjust obsolete comments, break some overly-long lines). Daniel Vérité and Tom Lane Discussion: https://postgr.es/m/4333844c-2244-4d6e-a49a-1d483fbe304f@manitou-mail.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/595580aa1243df5f199516ff11a27ba9680e6904 Modified Files -------------- src/bin/psql/common.c | 238 ++++++++++++++++++++++++++++---------------------- 1 file changed, 135 insertions(+), 103 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix psql's behavior with \g for a multiple-command string. @ 2022-10-03 19:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-10-03 19:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix psql's behavior with \g for a multiple-command string. The pre-v15 behavior was to discard all but the last result, but with the new behavior of printing all results by default, we will send each such result to the \g file. However, we're still opening and closing the \g file for each result, so you lose all but the last result anyway. Move the output-file state up to ExecQueryAndProcessResults so that we open/close the \g file only once per command string. To support this without changing other behavior, we must adjust PrintQueryResult to have separate FILE * arguments for query and status output (since status output has never gone to the \g file). That in turn makes it a good idea to push the responsibility for fflush'ing output down to PrintQueryTuples and PrintQueryStatus. Also fix an infinite loop if COPY IN/OUT is attempted in \watch. We used to reject that, but that error exit path got broken somewhere along the line in v15. There seems no real reason to reject it anyway as the code now stands, so just remove the error exit and make sure that COPY OUT data goes to the right place. Also remove PrintQueryResult's unused is_watch parameter, and make some other cosmetic cleanups (adjust obsolete comments, break some overly-long lines). Daniel Vérité and Tom Lane Discussion: https://postgr.es/m/4333844c-2244-4d6e-a49a-1d483fbe304f@manitou-mail.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4a79fd1a754edcc85f9b94f17a2fb4576becf0a3 Modified Files -------------- src/bin/psql/common.c | 238 ++++++++++++++++++++++++++++---------------------- 1 file changed, 135 insertions(+), 103 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-10-03 19:07 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-10-03 19:07 pgsql: Fix psql's behavior with \g for a multiple-command string. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-03 19:07 pgsql: Fix psql's behavior with \g for a multiple-command string. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox