pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix psql's behavior with \g for a multiple-command string.
Date: Mon, 03 Oct 2022 19:07:25 +0000
Message-ID: <E1ofQmj-000kw8-56@gemulon.postgresql.org> (raw)

Fix psql's behavior with \g for a multiple-command string.

The pre-v15 behavior was to discard all but the last result,
but with the new behavior of printing all results by default,
we will send each such result to the \g file.  However,
we're still opening and closing the \g file for each result,
so you lose all but the last result anyway.  Move the output-file
state up to ExecQueryAndProcessResults so that we open/close the
\g file only once per command string.

To support this without changing other behavior, we must
adjust PrintQueryResult to have separate FILE * arguments
for query and status output (since status output has never
gone to the \g file).  That in turn makes it a good idea
to push the responsibility for fflush'ing output down to
PrintQueryTuples and PrintQueryStatus.

Also fix an infinite loop if COPY IN/OUT is attempted in \watch.
We used to reject that, but that error exit path got broken
somewhere along the line in v15.  There seems no real reason
to reject it anyway as the code now stands, so just remove
the error exit and make sure that COPY OUT data goes to the
right place.

Also remove PrintQueryResult's unused is_watch parameter,
and make some other cosmetic cleanups (adjust obsolete
comments, break some overly-long lines).

Daniel Vérité and Tom Lane

Discussion: https://postgr.es/m/4333844c-2244-4d6e-a49a-1d483fbe304f@manitou-mail.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4a79fd1a754edcc85f9b94f17a2fb4576becf0a3

Modified Files
--------------
src/bin/psql/common.c | 238 ++++++++++++++++++++++++++++----------------------
1 file changed, 135 insertions(+), 103 deletions(-)



view thread (2+ messages)

Message-ID: <E1ofQmj-000kw8-56@gemulon.postgresql.org>
Permalink:  ../E1ofQmj-000kw8-56@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ofQmj-000kw8-56@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix psql's behavior with \g for a multiple-command string.
  In-Reply-To: <E1ofQmj-000kw8-56@gemulon.postgresql.org>
  References: <E1ofQmj-000kw8-56@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox