pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: windows: Adjust FD_SETSIZE via commandline define
Date: Thu, 06 Oct 2022 20:10:35 +0000
Message-ID: <E1ogXCU-001Cth-Hq@gemulon.postgresql.org> (raw)

windows: Adjust FD_SETSIZE via commandline define

When using precompiled headers, we cannot pre-define macros for the system
headers from within .c files, as headers are already processed before
the #define in the C file is reached. But we can pre-define using
-DFD_SETSIZE, as long as that's also used when building the precompiled header.

A few files #define FD_SETSIZE 1024 on windows, as the default is only 64. I
am hesitant to change FD_SETSIZE globally on windows, due to
src/backend/port/win32/socket.c using it to size on-stack arrays. Instead add
-DFD_SETSIZE=1024 when building the specific targets needing it.

We likely should move away from using select() in those places, but that's a
larger change.

Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de
Discussion: https://postgr.es/m/CA+hUKG+50eOUbN++ocDc0Qnp9Pvmou23DSXu=ZA6fepOcftKqA@mail.gmail.com
Discussion: https://postgr.es/m/20190826054000.GE7005%40paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4289263cf263ba36e474728f4a02ceb086903f81

Modified Files
--------------
src/bin/pgbench/Makefile     |  2 ++
src/bin/pgbench/meson.build  |  1 +
src/bin/pgbench/pgbench.c    |  4 ++--
src/fe_utils/Makefile        |  4 ++++
src/fe_utils/meson.build     |  1 +
src/fe_utils/parallel_slot.c |  4 ++--
src/tools/msvc/Mkvcbuild.pm  | 27 +++++++++++++++++++--------
7 files changed, 31 insertions(+), 12 deletions(-)



Message-ID: <E1ogXCU-001Cth-Hq@gemulon.postgresql.org>
Permalink:  ../E1ogXCU-001Cth-Hq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ogXCU-001Cth-Hq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: windows: Adjust FD_SETSIZE via commandline define
  In-Reply-To: <E1ogXCU-001Cth-Hq@gemulon.postgresql.org>
  References: <E1ogXCU-001Cth-Hq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox