pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix self-referencing foreign keys with partitioned tables
Date: Fri, 07 Oct 2022 17:39:07 +0000
Message-ID: <E1ogrJT-001LTb-0m@gemulon.postgresql.org> (raw)

Fix self-referencing foreign keys with partitioned tables

There are a number of bugs in this area.  Two of them are fixed here,
namely:
1. get_relation_idx_constraint_oid does not restrict the type of
   constraint that's returned, so with sufficient bad luck it can
   return the OID of a foreign key constraint.  This has the effect that
   a primary key in a partition can end up as a child of a foreign key,
   which makes no sense (it needs to be the child of the equivalent
   primary key.)
   Change the API contract so that only index-backed constraints are
   returned, mimicking get_constraint_index().

2. Both CloneFkReferenced and CloneFkReferencing clone a
   self-referencing foreign key, so the partition ends up with
   a duplicate foreign key.  Change the former function to ignore such
   constraints.

Add some tests to verify that things are better now.  (However, these
new tests show some additional misbehavior that will be fixed later --
namely that there's a constraint marked NOT VALID.)

Backpatch to 12, where these constraints are possible at all.

Author: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Discussion: https://postgr.es/m/20220603154232.1715b14c@karst

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7d520e68ea1e38a9f7ad1d04bd5f95d53eef6cd4

Modified Files
--------------
src/backend/catalog/pg_constraint.c       | 13 ++++-
src/backend/commands/tablecmds.c          | 13 +++++
src/test/regress/expected/foreign_key.out | 81 +++++++++++++++++++++++++++++++
src/test/regress/sql/foreign_key.sql      | 55 +++++++++++++++++++++
4 files changed, 161 insertions(+), 1 deletion(-)



view thread (5+ messages)

Message-ID: <E1ogrJT-001LTb-0m@gemulon.postgresql.org>
Permalink:  ../E1ogrJT-001LTb-0m@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ogrJT-001LTb-0m@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Fix self-referencing foreign keys with partitioned tables
  In-Reply-To: <E1ogrJT-001LTb-0m@gemulon.postgresql.org>
  References: <E1ogrJT-001LTb-0m@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox