pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: autoconf: Rely on ar supporting index creation
Date: Fri, 07 Oct 2022 19:04:04 +0000
Message-ID: <E1ogsdg-001LzD-90@gemulon.postgresql.org> (raw)

autoconf: Rely on ar supporting index creation

This way we don't need RANLIB anymore, making it a bit simpler for the meson
build to generate Makefile.global for PGXS compatibility.

FreeBSD, NetBSD, OpenBSD, the only platforms where we didn't use AROPT=crs,
all have supported the 's' option for a long time.

On macOS we ran ranlib after installing a static library. This was added a
long time ago, in 58ad65ec2def. I cannot reproduce an issue in more recent
macOS versions. This is removed now.

Based on discussion with Tom, I left the 'touch' at the end of static
libraries generation, added in 826eff57c4c, in place. While it looks like
current versions of Apple's ar/ranlib don't need it, it was needed not too
long ago.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20221005200710.luvw5evhwf6clig6@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2473cb9ff374dff99437138c144fab6d9f7dfd26

Modified Files
--------------
configure                      | 93 ------------------------------------------
configure.ac                   |  1 -
src/Makefile.global.in         |  2 +-
src/Makefile.shlib             |  7 +---
src/makefiles/Makefile.aix     |  3 --
src/makefiles/Makefile.cygwin  |  2 -
src/makefiles/Makefile.darwin  |  2 -
src/makefiles/Makefile.freebsd |  2 -
src/makefiles/Makefile.linux   |  2 -
src/makefiles/Makefile.netbsd  |  2 -
src/makefiles/Makefile.openbsd |  2 -
src/makefiles/Makefile.solaris |  2 -
src/makefiles/Makefile.win32   |  2 -
13 files changed, 2 insertions(+), 120 deletions(-)



Message-ID: <E1ogsdg-001LzD-90@gemulon.postgresql.org>
Permalink:  ../E1ogsdg-001LzD-90@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ogsdg-001LzD-90@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: autoconf: Rely on ar supporting index creation
  In-Reply-To: <E1ogsdg-001LzD-90@gemulon.postgresql.org>
  References: <E1ogsdg-001LzD-90@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox