pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify some maths in xlogreader.c
Date: Wed, 12 Oct 2022 01:00:15 +0000
Message-ID: <E1oiQ6Z-001yfG-9x@gemulon.postgresql.org> (raw)

Simplify some maths in xlogreader.c

An LSN was calculated from a segment number, a segment size and a
position offset, matching exactly the LSN given by the caller of
XLogReaderValidatePageHeader().  This change removes the extra LSN
calculation, relying only on the LSN given by the function caller
instead.

Author: Bharath Rupireddy
Reviewed-by: Richard Guo, Álvaro Herrera, Kyotaro Horiguchi
Discussion: https://postgr.es/m/CALj2ACXuh4Ms9j9sxMYdtHEe=5sFcyrs-GAHyADu_A_G71kZTg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a1176c67c42cf687675be762ebb6075e092d3d0a

Modified Files
--------------
src/backend/access/transam/xlogreader.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)



Message-ID: <E1oiQ6Z-001yfG-9x@gemulon.postgresql.org>
Permalink:  ../E1oiQ6Z-001yfG-9x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oiQ6Z-001yfG-9x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Simplify some maths in xlogreader.c
  In-Reply-To: <E1oiQ6Z-001yfG-9x@gemulon.postgresql.org>
  References: <E1oiQ6Z-001yfG-9x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox