pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reduce xlog.h inclusion footprint
Date: Wed, 12 Oct 2022 07:57:30 +0000
Message-ID: <E1oiWcL-0021Lm-Gw@gemulon.postgresql.org> (raw)

Reduce xlog.h inclusion footprint

This file needs xlogreader.h only for the XLogReaderState typedef; but
we can dodge that by forward-declaring it.  Many files use xlog.h for
reasons other than reading WAL, and it's not good to force all those
files to include xlogreader.h, so take it out.

Surprisingly, there is no fallout in core code from making this change.
Perhaps external code will have to start including xlogreader.h.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9c0de04242a160aa1d4afeefab7d2e40efd8255d

Modified Files
--------------
src/include/access/xlog.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)



Message-ID: <E1oiWcL-0021Lm-Gw@gemulon.postgresql.org>
Permalink:  ../E1oiWcL-0021Lm-Gw@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oiWcL-0021Lm-Gw@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Reduce xlog.h inclusion footprint
  In-Reply-To: <E1oiWcL-0021Lm-Gw@gemulon.postgresql.org>
  References: <E1oiWcL-0021Lm-Gw@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox