pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. 12+ messages / 1 participants [nested] [flat]
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/57dfb6ce61e0d04c525a7a0d251f17da871c6355 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL9_5_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/377b37cf7bf3ca1357a35f9ceae2bce36d2721d5 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/02d074e3ebca1ac0ccdc28a5ecf83ecf117d35b9 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3d7df87c4bba27f1d1dcc5d92e7997b82cedd458 Modified Files -------------- src/backend/parser/gram.y | 6 +++--- src/include/parser/kwlist.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9bfa043a1379b121fc4ee58dcf2606e151b11b9d Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/18e60712dd852f796bb31a64e8389d92be7cf9c6 Modified Files -------------- src/backend/parser/gram.y | 8 ++++---- src/include/parser/kwlist.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6618c276b7a0a8a9373789efc3e35c886f3d3490 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL9_2_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fec443414bbe82ae866eb15dab8cc4cc1847d838 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/24c4c2617138b1b14def8bd39dfe228c862ea129 Modified Files -------------- src/backend/parser/gram.y | 8 ++++---- src/include/parser/kwlist.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/717ec1aae90b91466809b1f6b0aa779dbf7a270b Modified Files -------------- src/backend/parser/gram.y | 8 ++++---- src/include/parser/kwlist.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL9_3_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ee4c44014400a79a69e094f60d39b1fdcd599998 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. @ 2022-10-16 19:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2022-10-16 19:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bc7a40b42eef717026d29b687157cd0af5adaadb Modified Files -------------- src/backend/parser/gram.y | 6 +++--- src/include/parser/kwlist.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
end of thread, other threads:[~2022-10-16 19:32 UTC | newest] Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us> 2022-10-16 19:32 pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox