pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename parser token REF to REF_P to avoid a symbol conflict.
Date: Sun, 16 Oct 2022 19:32:55 +0000
Message-ID: <E1ok9NW-002f9u-Ki@gemulon.postgresql.org> (raw)

Rename parser token REF to REF_P to avoid a symbol conflict.

In the latest version of Apple's macOS SDK, <sys/socket.h>
fails to compile if "REF" is #define'd as something.
Apple may or may not agree that this is a bug, and even if
they do accept the bug report I filed, they probably won't
fix it very quickly.  In the meantime, our back branches will all
fail to compile gram.y.  v15 and HEAD currently escape the problem
thanks to the refactoring done in 98e93a1fc, but that's purely
accidental.  Moreover, since that patch removed a widely-visible
inclusion of <netdb.h>, back-patching it seems too likely to break
third-party code.

Instead, change the token's code name to REF_P, following our usual
convention for naming parser tokens that are likely to have symbol
conflicts.  The effects of that should be localized to the grammar
and immediately surrounding files, so it seems like a safer answer.

Per project policy that we want to keep recently-out-of-support
branches buildable on modern systems, back-patch all the way to 9.2.

Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us

Branch
------
REL9_3_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ee4c44014400a79a69e094f60d39b1fdcd599998

Modified Files
--------------
src/backend/parser/gram.y   | 10 +++++-----
src/include/parser/kwlist.h |  2 +-
2 files changed, 6 insertions(+), 6 deletions(-)



view thread (12+ messages)  latest in thread

Message-ID: <E1ok9NW-002f9u-Ki@gemulon.postgresql.org>
Permalink:  ../E1ok9NW-002f9u-Ki@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ok9NW-002f9u-Ki@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Rename parser token REF to REF_P to avoid a symbol conflict.
  In-Reply-To: <E1ok9NW-002f9u-Ki@gemulon.postgresql.org>
  References: <E1ok9NW-002f9u-Ki@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox