From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix EXPLAIN of SEARCH BREADTH FIRST with a constant initial valu
Date: Sun, 16 Oct 2022 23:18:22 +0000
Message-ID: <E1okCth-002gUx-B0@gemulon.postgresql.org> (raw)
Fix EXPLAIN of SEARCH BREADTH FIRST with a constant initial value.
If the non-recursive term of a SEARCH BREADTH FIRST recursive
query has only constants in its target list, the planner will
fold the starting RowExpr added by rewrite into a simple Const
of type RECORD. The executor doesn't have any problem with
that --- but EXPLAIN VERBOSE will encounter the Const as the
ultimate source of truth about what the field names of the
SET column are, and it didn't know what to do with that.
Fortunately, we can pull the identifying typmod out of the
Const, in much the same way that record_out would.
For reasons that remain a bit obscure to me, this only fails
with SEARCH BREADTH FIRST, not SEARCH DEPTH FIRST or CYCLE.
But I added regression test cases for both of those options
too, just to make sure we don't break it in future.
Per bug #17644 from Matthijs van der Vleuten. Back-patch
to v14 where these constructs were added.
Discussion: https://postgr.es/m/17644-3bd1f3036d6d7a16@postgresql.org
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d4abb0bc5abb5dcb351956aed70f317a6bc494ba
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 3 +-
src/backend/utils/fmgr/funcapi.c | 34 +++++++++++
src/test/regress/expected/with.out | 120 +++++++++++++++++++++++++++++++++++++
src/test/regress/sql/with.sql | 52 ++++++++++++++++
4 files changed, 208 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Fix EXPLAIN of SEARCH BREADTH FIRST with a constant initial valu
In-Reply-To: <E1okCth-002gUx-B0@gemulon.postgresql.org>
References: <E1okCth-002gUx-B0@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox