pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION
2+ messages / 1 participants
[nested] [flat]

* pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION
@ 2022-10-18 09:47  Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2022-10-18 09:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION

The original hint says to use SET PUBLICATION when really ADD/DROP
PUBLICATION is called for, so this is arguably a bug fix.

Also, a very similar message elsewhere was using an inconsistent
SQLSTATE.

While at it, unwrap some strings.

Backpatch to 15.

Author: Hou zj <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/OS0PR01MB57160AD0E7386547BA978EB394299@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/915a6c4e22ecc4775b9ed18312bf12d896cd2b11

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION
@ 2022-10-18 09:47  Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2022-10-18 09:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION

The original hint says to use SET PUBLICATION when really ADD/DROP
PUBLICATION is called for, so this is arguably a bug fix.

Also, a very similar message elsewhere was using an inconsistent
SQLSTATE.

While at it, unwrap some strings.

Backpatch to 15.

Author: Hou zj <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/OS0PR01MB57160AD0E7386547BA978EB394299@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/25fb9579bbb97c65d6b007c3de803c81abb4b240

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-10-18 09:47 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 09:47 pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-10-18 09:47 pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox