pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Date: Tue, 18 Oct 2022 09:47:48 +0000
Message-ID: <E1okjCN-002tzM-Q2@gemulon.postgresql.org> (raw)

Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION

The original hint says to use SET PUBLICATION when really ADD/DROP
PUBLICATION is called for, so this is arguably a bug fix.

Also, a very similar message elsewhere was using an inconsistent
SQLSTATE.

While at it, unwrap some strings.

Backpatch to 15.

Author: Hou zj <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/OS0PR01MB57160AD0E7386547BA978EB394299@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/915a6c4e22ecc4775b9ed18312bf12d896cd2b11

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1okjCN-002tzM-Q2@gemulon.postgresql.org>
Permalink:  ../E1okjCN-002tzM-Q2@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1okjCN-002tzM-Q2@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION
  In-Reply-To: <E1okjCN-002tzM-Q2@gemulon.postgresql.org>
  References: <E1okjCN-002tzM-Q2@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox