pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Rework shutdown callback of archiver modules
2+ messages / 1 participants
[nested] [flat]

* pgsql: Rework shutdown callback of archiver modules
@ 2022-10-19 05:07  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2022-10-19 05:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Rework shutdown callback of archiver modules

As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.

Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.

While on it, this commit adds some testing coverage for the shutdown
callback.  Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.

Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5d2a47a2924240606ce1c57c98490fa41752ad41

Modified Files
--------------
doc/src/sgml/config.sgml                  |  5 +++--
src/backend/postmaster/pgarch.c           | 27 ++++++++-------------------
src/backend/postmaster/shell_archive.c    |  8 ++++++++
src/test/recovery/t/020_archive_status.pl | 14 ++++++++++++++
4 files changed, 33 insertions(+), 21 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Rework shutdown callback of archiver modules
@ 2022-10-19 05:07  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2022-10-19 05:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Rework shutdown callback of archiver modules

As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.

Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.

While on it, this commit adds some testing coverage for the shutdown
callback.  Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.

Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9668c4a6618cc4a7a94f4bc0ad5685dd596bab63

Modified Files
--------------
doc/src/sgml/config.sgml                  |  5 +++--
src/backend/postmaster/pgarch.c           | 27 ++++++++-------------------
src/backend/postmaster/shell_archive.c    |  8 ++++++++
src/test/recovery/t/020_archive_status.pl | 14 ++++++++++++++
4 files changed, 33 insertions(+), 21 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-10-19 05:07 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 05:07 pgsql: Rework shutdown callback of archiver modules Michael Paquier <michael@paquier.xyz>
2022-10-19 05:07 pgsql: Rework shutdown callback of archiver modules Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox