pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rework shutdown callback of archiver modules
Date: Wed, 19 Oct 2022 05:07:45 +0000
Message-ID: <E1ol1Iu-0031C2-VN@gemulon.postgresql.org> (raw)

Rework shutdown callback of archiver modules

As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.

Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.

While on it, this commit adds some testing coverage for the shutdown
callback.  Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.

Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5d2a47a2924240606ce1c57c98490fa41752ad41

Modified Files
--------------
doc/src/sgml/config.sgml                  |  5 +++--
src/backend/postmaster/pgarch.c           | 27 ++++++++-------------------
src/backend/postmaster/shell_archive.c    |  8 ++++++++
src/test/recovery/t/020_archive_status.pl | 14 ++++++++++++++
4 files changed, 33 insertions(+), 21 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1ol1Iu-0031C2-VN@gemulon.postgresql.org>
Permalink:  ../E1ol1Iu-0031C2-VN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ol1Iu-0031C2-VN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Rework shutdown callback of archiver modules
  In-Reply-To: <E1ol1Iu-0031C2-VN@gemulon.postgresql.org>
  References: <E1ol1Iu-0031C2-VN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox