pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Better handle interrupting TAP tests
Date: Wed, 19 Oct 2022 15:37:04 +0000
Message-ID: <E1olB7v-0035BS-LU@gemulon.postgresql.org> (raw)

Better handle interrupting TAP tests

Set up a signal handler for INT/TERM so that we run our END block if we
get them.  In END, if the exit status indicates a problem, call
_update_pid(-1) to improve chances of the stop working in case start()
hasn't returned yet.

Also, change END's teardown_node() so that it passes fail_ok=>1, so that
if a node fails to stop, we still stop the other nodes in the same test.

Per complaint from Andres Freund.

This doesn't seem important enough to backpatch, at least for now.

Discussion: https://postgr.es/m/20220930040734.mbted42oiynhn2t6@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/460c0076e8de6233eee53f4d6c175b04d8d41de9

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)



Message-ID: <E1olB7v-0035BS-LU@gemulon.postgresql.org>
Permalink:  ../E1olB7v-0035BS-LU@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1olB7v-0035BS-LU@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Better handle interrupting TAP tests
  In-Reply-To: <E1olB7v-0035BS-LU@gemulon.postgresql.org>
  References: <E1olB7v-0035BS-LU@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox