pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix assertion failures while processing NEW_CID record in logica
Date: Thu, 20 Oct 2022 04:23:45 +0000
Message-ID: <E1olN5s-0039sZ-Vj@gemulon.postgresql.org> (raw)

Fix assertion failures while processing NEW_CID record in logical decoding.

When the logical decoding restarts from NEW_CID, since there is no
association between the top transaction and its subtransaction, both are
created as top transactions and have the same LSN. This caused the
assertion failure in AssertTXNLsnOrder().

This patch skips the assertion check until we reach the LSN at which we
start decoding the contents of the transaction, specifically
start_decoding_at LSN in SnapBuild. This is okay because we don't
guarantee to make the association between top transaction and
subtransaction until we try to decode the actual contents of transaction.
The ordering of the records prior to the start_decoding_at LSN should have
been checked before the restart.

The other assertion failure is due to the reason that we forgot to track
that we have considered top-level transaction id in the list of catalog
changing transactions that were committed when one of its subtransactions
is marked as containing catalog change.

Reported-by: Tomas Vondra, Osumi Takamichi
Author: Masahiko Sawada, Kuroda Hayato
Reviewed-by: Amit Kapila, Dilip Kumar, Kuroda Hayato, Kyotaro Horiguchi, Masahiko Sawada
Backpatch-through: 10
Discussion: https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com
Discussion: https://postgr.es/m/TYCPR01MB83733C6CEAE47D0280814D5AED7A9%40TYCPR01MB8373.jpnprd01.prod.outlook.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1bf4d92060eeefa40b4d63d246a490379a5cec78

Modified Files
--------------
.../expected/catalog_change_snapshot.out           | 45 ++++++++++++++++++++++
.../specs/catalog_change_snapshot.spec             | 16 ++++++++
src/backend/replication/logical/reorderbuffer.c    | 14 +++++++
src/backend/replication/logical/snapbuild.c        |  3 ++
4 files changed, 78 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1olN5s-0039sZ-Vj@gemulon.postgresql.org>
Permalink:  ../E1olN5s-0039sZ-Vj@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1olN5s-0039sZ-Vj@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Fix assertion failures while processing NEW_CID record in logica
  In-Reply-To: <E1olN5s-0039sZ-Vj@gemulon.postgresql.org>
  References: <E1olN5s-0039sZ-Vj@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox