pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_basebackup: Fix cross-platform tablespace relocation.
Date: Fri, 21 Oct 2022 13:15:27 +0000
Message-ID: <E1olrrz-0009qH-6i@gemulon.postgresql.org> (raw)

pg_basebackup: Fix cross-platform tablespace relocation.

Specifically, when pg_basebackup is invoked with -Tx=y, don't error
out if x could plausibly be an absolute path either on Windows or on
non-Windows systems. We don't know whether the remote system is
running the same OS as the local system, so it's not appropriate to
assume that our local rule about absolute pathnames is the same as
the rule on the remote system.

Patch by me, reviewed by Tom Lane, Andrew Dunstan, and
Davinder Singh.

Discussion: http://postgr.es/m/CA+TgmoY+jC3YiskomvYKDPK3FbrmsDU7_8+wMHt02HOdJeRb0g@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/475e9daf39799b7ae160753761318193480d5942

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 20 +++++++++++++++-----
src/include/port.h                    | 34 +++++++++++++++++++---------------
2 files changed, 34 insertions(+), 20 deletions(-)



view thread (7+ messages)

Message-ID: <E1olrrz-0009qH-6i@gemulon.postgresql.org>
Permalink:  ../E1olrrz-0009qH-6i@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1olrrz-0009qH-6i@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: pg_basebackup: Fix cross-platform tablespace relocation.
  In-Reply-To: <E1olrrz-0009qH-6i@gemulon.postgresql.org>
  References: <E1olrrz-0009qH-6i@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox