From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix and improve TAP tests for pg_hba.conf and regexps
Date: Mon, 24 Oct 2022 04:59:19 +0000
Message-ID: <E1ompYV-000YEs-9Y@gemulon.postgresql.org> (raw)
Fix and improve TAP tests for pg_hba.conf and regexps
The new tests have been reporting a warning hidden in the logs, as of
"Odd number of elements in hash assignment" (perlcritic or similar did
not report an issue, actually). This comes down to a typo in the test
"matching regexp for username" for a double-quoted regexp using commas,
where we passed an extra argument. The test is intended to pass, but
this was causing the test to fail. This also pointed out that the
newly-added role "md5,role" lacks an entry in the password file used to
provide the password, so add one.
While on it, make the tests pickier by checking the contents of the logs
generated on successful authentication.
Oversights in 8fea868.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/14a737bfdbe4f2328d7f333b207f52f9ed4ee722
Modified Files
--------------
src/test/authentication/t/001_password.pl | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Fix and improve TAP tests for pg_hba.conf and regexps
In-Reply-To: <E1ompYV-000YEs-9Y@gemulon.postgresql.org>
References: <E1ompYV-000YEs-9Y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox