pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve coverage of ruleutils.c for SQLValueFunctions
Date: Mon, 24 Oct 2022 07:56:50 +0000
Message-ID: <E1omsKH-000ZQ8-MM@gemulon.postgresql.org> (raw)

Improve coverage of ruleutils.c for SQLValueFunctions

While looking at how these are handled in the parser and the executor, I
have noticed that there is no test coverage for most of these when
reverse-engineering an expression for a SQLValueFunction node in
ruleutils.c, including how these are reparsed when included in a FROM
clause.  Some hacking in this area has showed me that these could break
easily, so add some coverage to track the existing compatibility.

Extracted from a much larger patch by me.

Discussion: https://postgr.es/m/YzaG3MoryCguUOym@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2e0d80c5bb722fb49a4cdc44b0c715ec77c83f79

Modified Files
--------------
src/test/regress/expected/create_view.out | 82 ++++++++++++++++++++++++++++++-
src/test/regress/sql/create_view.sql      | 33 ++++++++++++-
2 files changed, 112 insertions(+), 3 deletions(-)



Message-ID: <E1omsKH-000ZQ8-MM@gemulon.postgresql.org>
Permalink:  ../E1omsKH-000ZQ8-MM@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1omsKH-000ZQ8-MM@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Improve coverage of ruleutils.c for SQLValueFunctions
  In-Reply-To: <E1omsKH-000ZQ8-MM@gemulon.postgresql.org>
  References: <E1omsKH-000ZQ8-MM@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox