pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix recently added incorrect assertion
Date: Mon, 24 Oct 2022 10:05:10 +0000
Message-ID: <E1omuKU-000aIV-DU@gemulon.postgresql.org> (raw)

Fix recently added incorrect assertion

Commit df3737a651f4 added an incorrect assertion about the preconditions
for invoking the backup cleanup callback: it misfires at session end in
case a backup completes successfully.  Fix it, using coding from Michaƫl
Paquier.  Also add some tests for the various cases.

Reported by Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20221021.161038.1277961198945653224.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8328a15f8f95cad3fa99bbab551cade0a8403708

Modified Files
--------------
src/backend/access/transam/xlog.c         |  5 ++---
src/test/recovery/t/020_archive_status.pl | 14 ++++++++++++++
2 files changed, 16 insertions(+), 3 deletions(-)



Message-ID: <E1omuKU-000aIV-DU@gemulon.postgresql.org>
Permalink:  ../E1omuKU-000aIV-DU@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1omuKU-000aIV-DU@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Fix recently added incorrect assertion
  In-Reply-To: <E1omuKU-000aIV-DU@gemulon.postgresql.org>
  References: <E1omuKU-000aIV-DU@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox