pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix variable assignment thinko in hba.c
Date: Wed, 26 Oct 2022 03:58:10 +0000
Message-ID: <E1onXYP-000pwm-GN@gemulon.postgresql.org> (raw)

Fix variable assignment thinko in hba.c

The intention behind 1b73d0b was to limit the use of TokenizedAuthLine,
but I have fat-fingered one location in parse_hba_line() when creating
the HbaLine, where this should use the local variable and not the value
coming from TokenizedAuthLine.  This logic is the exactly the same, but
let's be clean about all that on consistency grounds.

Reported-by: Julien Rouhaud
Discussion: https://postgr.es/m/20221026032730.k3sib5krgm7l6njk@jrouhaud

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/37d264478ab47e8fa03751c39ba2c5dd447b89c8

Modified Files
--------------
src/backend/libpq/hba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1onXYP-000pwm-GN@gemulon.postgresql.org>
Permalink:  ../E1onXYP-000pwm-GN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1onXYP-000pwm-GN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix variable assignment thinko in hba.c
  In-Reply-To: <E1onXYP-000pwm-GN@gemulon.postgresql.org>
  References: <E1onXYP-000pwm-GN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox