pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move pg_pwritev_with_retry() to src/common/file_utils.c
Date: Thu, 27 Oct 2022 05:41:00 +0000
Message-ID: <E1onvdU-000zKk-6O@gemulon.postgresql.org> (raw)

Move pg_pwritev_with_retry() to src/common/file_utils.c

This commit moves pg_pwritev_with_retry(), a convenience wrapper of
pg_writev() able to handle partial writes, to common/file_utils.c so
that the frontend code is able to use it.  A first use-case targetted
for this routine is pg_basebackup and pg_receivewal, for the
zero-padding of a newly-initialized WAL segment.  This is used currently
in the backend when the GUC wal_init_zero is enabled (default).

Author: Bharath Rupireddy
Reviewed-by: Nathan Bossart, Thomas Munro
Discussion: https://postgr.es/m/CALj2ACUq7nAb7=bJNbK3yYmp-SZhJcXFR_pLk8un6XgDzDF3OA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4ab8c81bd90ae442dbd092df04a12dbb7e68f562

Modified Files
--------------
src/backend/storage/file/fd.c   | 65 ---------------------------------------
src/common/file_utils.c         | 67 +++++++++++++++++++++++++++++++++++++++++
src/include/common/file_utils.h |  7 +++++
src/include/storage/fd.h        |  6 ----
4 files changed, 74 insertions(+), 71 deletions(-)



Message-ID: <E1onvdU-000zKk-6O@gemulon.postgresql.org>
Permalink:  ../E1onvdU-000zKk-6O@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1onvdU-000zKk-6O@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Move pg_pwritev_with_retry() to src/common/file_utils.c
  In-Reply-To: <E1onvdU-000zKk-6O@gemulon.postgresql.org>
  References: <E1onvdU-000zKk-6O@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox