pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid making commutatively-duplicate clauses in EquivalenceClass
Date: Thu, 27 Oct 2022 18:42:39 +0000
Message-ID: <E1oo7pv-00140y-AZ@gemulon.postgresql.org> (raw)

Avoid making commutatively-duplicate clauses in EquivalenceClasses.

When we decide we need to make a derived clause equating a.x and
b.y, we already will re-use a previously-made clause "a.x = b.y".
But we might instead have "b.y = a.x", which is perfectly usable
because equivclass.c has never promised anything about the
operand order in clauses it builds.  Saving construction of a
new RestrictInfo doesn't matter all that much in itself --- but
because we cache selectivity estimates and so on per-RestrictInfo,
there's a possibility of saving a fair amount of duplicative
effort downstream.

Hence, check for commutative matches as well as direct ones when
seeing if we have a pre-existing clause.  This changes the visible
clause order in several regression test cases, but they're all
clearly-insignificant changes.

Checking for the reverse operand order is simple enough, but
if we wanted to check for operator OID match we'd need to call
get_commutator here, which is not so cheap.  I concluded that
we don't really need the operator check anyway, so I just
removed it.  It's unlikely that an opfamily contains more than
one applicable operator for a given pair of operand datatypes;
and if it does they had better give the same answers, so there
seems little need to insist that we use exactly the one
select_equality_operator chose.

Using the current core regression suite as a test case, I see
this change reducing the number of new join clauses built by
create_join_clause from 9673 to 5142 (out of 26652 calls).
So not quite 50% savings, but pretty close to it.

Discussion: https://postgr.es/m/78062.1666735746@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a5fc46414deb7cbcd4cec1275efac69b9ac10500

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 52 +++++++++++++-------------
src/backend/optimizer/path/equivclass.c        | 28 ++++++++++----
src/test/regress/expected/join.out             | 10 ++---
src/test/regress/expected/partition_join.out   | 14 +++----
src/test/regress/expected/tidscan.out          |  2 +-
5 files changed, 59 insertions(+), 47 deletions(-)



Message-ID: <E1oo7pv-00140y-AZ@gemulon.postgresql.org>
Permalink:  ../E1oo7pv-00140y-AZ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oo7pv-00140y-AZ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Avoid making commutatively-duplicate clauses in EquivalenceClass
  In-Reply-To: <E1oo7pv-00140y-AZ@gemulon.postgresql.org>
  References: <E1oo7pv-00140y-AZ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox